Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated .prettierrc to use '"tabWidth": 2' #737

Merged
merged 3 commits into from
Aug 22, 2024

Conversation

jongpie
Copy link
Owner

@jongpie jongpie commented Aug 21, 2024

Resolved #723 by switching to 2 spaces instead of 4 for all files in the repo

  • Added *.xml to .prettierignore and updated .prettierrc to remove formatting of XML files. Now XML metadata files will be committed using the exact format returned by Salesforce.
  • Updated .prettierrc to use "tabWidth": 2 (instead of 4)
  • Reformatted all files in the repo

…d all files in the repo

Also added "*.xml" to .prettierignore and updated .prettierrc to remove formatting of XML files. Now XML metadata files will be committed using the exact format returned by Salesforce.
@jongpie jongpie force-pushed the feature/reduce-prettier-tab-width branch from 7d8dd9a to e138f6d Compare August 22, 2024 03:34
@jongpie jongpie temporarily deployed to Experience Cloud Scratch Org August 22, 2024 03:39 — with GitHub Actions Inactive
@jongpie jongpie temporarily deployed to Base Scratch Org August 22, 2024 03:39 — with GitHub Actions Inactive
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 97.01789% with 15 lines in your changes missing coverage. Please review.

Project coverage is 95.44%. Comparing base (f01faf0) to head (e138f6d).

Files Patch % Lines
...e/main/configuration/classes/LoggerFieldMapper.cls 83.87% 10 Missing ⚠️
...r/core/main/configuration/classes/LoggerPlugin.cls 96.92% 2 Missing ⚠️
.../main/configuration/classes/LoggerScenarioRule.cls 92.30% 2 Missing ⚠️
...er/core/main/configuration/classes/LoggerCache.cls 98.83% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #737      +/-   ##
==========================================
+ Coverage   95.37%   95.44%   +0.06%     
==========================================
  Files          51       51              
  Lines        5648     5620      -28     
==========================================
- Hits         5387     5364      -23     
+ Misses        261      256       -5     
Flag Coverage Δ
Apex 95.44% <97.01%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jongpie jongpie merged commit 6664ed1 into main Aug 22, 2024
1 check passed
@jongpie jongpie deleted the feature/reduce-prettier-tab-width branch August 22, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update prettier config to use 2 spaces (instead of 4)
2 participants