Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update prettier config to use 2 spaces (instead of 4) #723

Closed
jongpie opened this issue Jul 24, 2024 · 2 comments · Fixed by #737
Closed

Update prettier config to use 2 spaces (instead of 4) #723

jongpie opened this issue Jul 24, 2024 · 2 comments · Fixed by #737
Assignees
Labels

Comments

@jongpie
Copy link
Owner

jongpie commented Jul 24, 2024

Once upon a time, I liked using 4 spaces for indentation. But now, I used 2 spaces in pretty much all of my other codebases, except Nebula Logger.

This change shouldn't have any functional impact, but it will change nearly ever file in the repo, so this needs to be done when there aren't any other open PRs/work-in-progress:

  • Update .prettierrc to use "tabWidth": 2
  • Re-run prettier on all files in the repo

I'm not sure if it makes sense to create a release/package version just for this change, but.... maybe?

@jamessimone
Copy link
Collaborator

This is the best

@jongpie jongpie self-assigned this Jul 24, 2024
jongpie added a commit that referenced this issue Aug 22, 2024
- Added *.xml to .prettierignore and updated .prettierrc to remove formatting of XML files. Now XML metadata files will be committed using the exact format returned by Salesforce.
- Resolved #723 by updating .prettierrc to use '"tabWidth": 2' (instead of 4)
- Reformatted all files in the repo
@TrangOul
Copy link
Contributor

Even better, use tabs. Each dev can set the desired tab size. And the resulting file size is slightly smaller.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants