Add sane default instance dir, make configurable #52
Conversation
Use a non privileged directory for the app instance. Use ~/.cache/grip by default but allow the user to specify an alternative directory with the --app-dir option. Fixes #38
|
That is essential when |
|
Can this be merged? |
| if app_dir is not None: | ||
| instance_path = os.path.abspath(app_dir) | ||
| else: | ||
| instance_path = os.path.expanduser("~/.cache/grip") |
There was a problem hiding this comment.
Could you use os.path.join('~/.cache/grip') for cross-platform paths?
|
Ok. Will do once that comment is resolved. |
|
Also, is |
|
Hey @jdevera. First off, thanks for opening up this pull request. I pulled in #39 for now so nobody needs to use I'm curious though. And anyone in this thread can speak up. Why does grip's config directory need to be configurable? Aside from name collisions--which we'll cross that bridge when we get there--what other compelling reasons are there for configuring this location? Like I mentioned in #38, I'd like to have a good reason before introducing another configuration option, since each one makes the project just a little more complex. |
|
Closing this due to inactivity. Thanks, all. |
|
FYI, just pulled in a similar change that uses an environment variable instead of a CLI option in #117. This lets it be configurable while keeping the common case clean. Cheers. |
Use a non privileged directory for the app instance. Use ~/.cache/grip
by default but allow the user to specify an alternative directory with
the --app-dir option.
Fixes #38