Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce environment variable GRIPHOME for greater customizability of instance_path #117

Merged
merged 1 commit into from
May 3, 2015

Conversation

zmwangx
Copy link
Contributor

@zmwangx zmwangx commented May 3, 2015

I would like to declutter my home directory and put grip's config file settings.py in ~/.config/grip/settings.py (per XDG Base Directory Specification) for easier versioning, but this is currently impossible, unless I missed something.

In this PR, I use the environment variable GRIPHOME as instance_path if set, and fall
back to the default ~/.grip otherwise. This way I can set GRIPHOME to ~/.config/grip to my liking, and others could set it to something else that they prefer.

Use the environment variable GRIPHOME as instance_path if set, and fall
back to the default ~/.grip otherwise.
@joeyespo
Copy link
Owner

joeyespo commented May 3, 2015

Looks good! There's no way to do this right now, so this looks like a good addition.

Thanks, @zmwangx!

joeyespo added a commit that referenced this pull request May 3, 2015
Introduce environment variable GRIPHOME for greater customizability of instance_path
@joeyespo joeyespo merged commit bf91ec2 into joeyespo:master May 3, 2015
@zmwangx
Copy link
Contributor Author

zmwangx commented May 3, 2015

Thanks for the lightening fast response!

zmwangx added a commit to zmwangx/dotfiles that referenced this pull request Jul 20, 2015
New:
- grip  -- 3.3.0 includes joeyespo/grip#117, so
           I no longer need to do a local install
- twine -- I always use twine for uploading to PyPI, but forgot to
           include it here

Obsolete:
- python-onedrive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants