Handle an HTTP Response with a Content-type but no body. #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an error that was being raised when the request specified a content type and an encoding BUT the body of the response is nil. In that situation, we just want to return nil.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In c46663d a change was made to clean up the
encode_with_ruby_encodingmethod.Previously, the
force_encodingmethod was always called and then there was arescuethat would just return thebody. If a request had anilbody, therescuemade sure that anilvalue (the originalbody) would be returned.After c46663d, if a response had a
nilbody, an error would be thrown when parsing the response.This PR includes a spec that reproduces the error and a fix that adds a
nilcheck to make sure we do not callforce_encodingonnil. If thebodyisnil, we will returnnil. This matches the previous behavior.