Response with Content-Encoding but empty body breaks

[ghostganz]

I have a service that gives 304 Not Modified responses and has a response header "Content-Encoding: gzip" at the same time. (Arguably a bug in Rack::Deflate, but that's another story).

Since the 304 response has no body, HTTParty chokes when trying to decompress the body:

httparty (0.12.0) lib/httparty/request.rb:272:in `initialize'
httparty (0.12.0) lib/httparty/request.rb:272:in `new'
httparty (0.12.0) lib/httparty/request.rb:272:in `handle_deflation'
httparty (0.12.0) lib/httparty/request.rb:106:in `perform'
httparty (0.12.0) lib/httparty.rb:486:in `perform_request'
httparty (0.12.0) lib/httparty.rb:423:in `get'
httparty (0.12.0) lib/httparty.rb:518:in `get'
...

The failing line in HTTParty:

body_io = StringIO.new(last_response.body)

[ghostganz]

Actually Rack::Deflate is innocent, we have a strangely configured proxy I think. Still, it would be nice if HTTParty could handle it.

[jnunemaker]

Yeah, does not seem like an httparty bug per say but we can probably handle it more gracefully. What is the actual error? You have the backtrace but not the exception.

[ghostganz]

Sorry, it's TypeError with "can't convert nil into String".

[rusikf]

@ghostganz can you provide failing test for this issue ?

[jnunemaker]

I think #530 closes this. Closing but let me know if I'm wrong.