-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use single gateway streamer for CompositeGateway #5598
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5598 +/- ##
==========================================
+ Coverage 86.52% 87.99% +1.47%
==========================================
Files 124 124
Lines 10069 10070 +1
==========================================
+ Hits 8712 8861 +149
+ Misses 1357 1209 -148
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make sure the close method is safe
I believe it's fine without a lock. The streamer.close is already called once, when the runtime is shutdown |
The lock is not necessary since the GatewayRuntime handles the |
Goals: