Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use single GatewayStreamer object for all gateways in the CompositeGateway #5592

Closed
girishc13 opened this issue Jan 11, 2023 · 0 comments · Fixed by #5598
Closed

feat: use single GatewayStreamer object for all gateways in the CompositeGateway #5592

girishc13 opened this issue Jan 11, 2023 · 0 comments · Fixed by #5598

Comments

@girishc13
Copy link
Contributor

The GatewayStreamer object is instantiated in the BaseGateway. The CompositeGateway itself is a sub class of the BaseGateway and the respective protocol specific Gateway is also a sub class of the BaseGateway. Which means that there is at least one streamer object for the CompositeGateway class and one for each protocol specific gateway. This complicates the warmup logic (#5467) because by default only the CompositeGateway streamer object is being triggered. Using a single streamer object is more compact and reduces the overhead of creating multiple connection pools within each streamer object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant