Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update table.sass, fix color hover on striped rows [Fix #1710] #1744

Merged
merged 1 commit into from
Oct 7, 2018
Merged

Update table.sass, fix color hover on striped rows [Fix #1710] #1744

merged 1 commit into from
Oct 7, 2018

Conversation

EEParker
Copy link
Contributor

This is a bugfix for #1710.

Proposed solution

This is a very simple change to fix hover color on striped tables.

Tradeoffs

N/A

Testing Done

Result in screenshot:
image
image

@EEParker EEParker changed the title Update table.sass, fix color hover on striped rows Fix #1710 Update table.sass, fix color hover on striped rows Mar 21, 2018
@EEParker EEParker changed the title Fix #1710 Update table.sass, fix color hover on striped rows Update table.sass, fix color hover on striped rows [Fix #1710] Mar 21, 2018
@jgthms
Copy link
Owner

jgthms commented Apr 8, 2018

I'm not sure what this is fixing? 🤔

Do you have a Codepen with before and after?

@EEParker
Copy link
Contributor Author

EEParker commented Apr 9, 2018

The table hover color is always the $table-striped-row-even-hover-background-color and $table-row-hover-background-color is ignored when striped tables are on.

With this in place, the hover color toggles between $table-striped-row-even-hover-background-color and $table-row-hover-background-color if your mouse is over an alt row.

Perhaps this is not the intended functionality and just a documentation and understanding issue?

@mallardduck
Copy link
Contributor

@jgthms I believe that the compiled code would provide these results: https://codepen.io/mallardduck/pen/gKbRgv

I tink @EEParker is correct that the issue could either be in the documentation or code. I believe their solution resolves the issue without needing to update documentation.

From what I see it does fix the issue in #1710

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants