Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable $table-striped-row-even-hover-background-color is not accurate in source #1710

Closed
phillycheeze opened this issue Mar 8, 2018 · 0 comments · Fixed by tghelere/valorize-vidas#6 · May be fixed by devopsred/gaia#6, anikets43/angular-ngrx-socket-frontend#4 or jwlh/WDI_GROUP_PROJECT#2

Comments

@phillycheeze
Copy link

phillycheeze commented Mar 8, 2018

This is about The Docs.

Overview of the problem

This is about the Bulma *Docs
I'm using Bulma version [0.6.0]
I am sure this issue is not a duplicate

Description

The variable name for $table-striped-row-even-hover-background-color is confusing since it applies to all rows, not just the "even" rows. Looking through the source code, it is confirmed that the selector is working on all table rows and not just even rows.

While this is very low priority issue, it is confusing since there is $table-row-hover-background-color that does not trigger if the table is both "hoverable" and "striped". In that case you'd think there is a variable for the hover color, and indeed there is. But the variable name has the word "even" in it which for all other variables only applies for striped tables on even indexed rows.

This involves changing the source variable name, but I marked this issue as affecting the "docs" due to it being so simple and initially confusing in the documentation. It seems the variable should just remove the "even" in it and everything would make sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment