Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate plugin conventions to extensions #72

Merged
merged 1 commit into from
Oct 1, 2023
Merged

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented Sep 25, 2023

  • All tests passed. If this feature is not already covered by the tests, I added new
    tests.

Fix #43
Supersedes #62

The notion of Gradle conventions has been deprecated.
In essence, this pull request is intended migrate of the plugin to the extensions concept by eliminating all occurrences of ConfigureUtil.configureUsing(Closure closure) and replacing them with ObjectFactory.newInstance(Class, Object...). It also replaces all references to ConventionUtils with ExtensionsUtils.

As per the information provided in the ConfigureUtil documentation:

Gradle automatically generates a Closure-taking method at runtime for each method with an Action as a single argument as long as the object is created with ObjectFactory.newInstance(Class, Object...).

To utilize ObjectFactory.newInstance, a constructor must have the @Inject annotation applied.

@yahavi yahavi added the improvement Automatically generated release notes label Sep 25, 2023
@yahavi yahavi requested review from eyalbe4 and attiasas September 25, 2023 15:04
@yahavi yahavi self-assigned this Sep 25, 2023
@yahavi yahavi added the safe to test Approve running tests on a pull request label Sep 25, 2023
@github-actions github-actions bot removed the safe to test Approve running tests on a pull request label Sep 25, 2023
@github-actions
Copy link


@yahavi yahavi merged commit 1e30e99 into jfrog:main Oct 1, 2023
@yahavi yahavi deleted the extensions branch October 1, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Project.getConvention() method has been deprecated ConfigureUtil deprecation reported on Gradle 7.6+
2 participants