Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Project.getConvention() method has been deprecated #43

Closed
ghost opened this issue Jul 20, 2023 · 4 comments · Fixed by #72
Closed

The Project.getConvention() method has been deprecated #43

ghost opened this issue Jul 20, 2023 · 4 comments · Fixed by #72
Labels
bug Something isn't working

Comments

@ghost
Copy link

ghost commented Jul 20, 2023

Describe the bug

When building on Gradle 8.2 I get the following warning

The Project.getConvention() method has been deprecated. This is scheduled to be removed in Gradle 9.0. Consult the upgrading guide for further information: https://docs.gradle.org/8.2.1/userguide/upgrading_version_8.html#deprecated_access_to_conventions
        at org.gradle.api.internal.project.DefaultProject.getConvention(DefaultProject.java:593)
        at org.jfrog.gradle.plugin.artifactory.utils.ConventionUtils.getOrCreateArtifactoryConvention(ConventionUtils.java:28)
        at org.jfrog.gradle.plugin.artifactory.ArtifactoryPlugin.apply(ArtifactoryPlugin.java:27)
        at org.jfrog.gradle.plugin.artifactory.ArtifactoryPlugin.apply(ArtifactoryPlugin.java:17)
        at org.gradle.api.internal.plugins.ImperativeOnlyPluginTarget.applyImperative(ImperativeOnlyPluginTarget.java:43)

Project.getConvention() is deprecated for removal in Gradle 9.0

Current behavior

The Artifactory plugin in version 5.0.3 emits warnings about using deprecated Gradle features.

Reproduction steps

No response

Expected behavior

No response

Artifactory Gradle plugin version

5.0.3

Operating system type and version

MacOS aarch64

JFrog Artifactory version

N/A

Gradle version

8.2.1

@ghost ghost added the bug Something isn't working label Jul 20, 2023
@bmuschko
Copy link

What's the way forward here? Is JFrog planning to fix the issue or would you rather want to receive a pull request?

@yahavi
Copy link
Member

yahavi commented Aug 29, 2023

@bmuschko,
Thanks for reporting this issue.
We're more than happy to accept code contributions for this plugin.

@yahavi
Copy link
Member

yahavi commented Oct 4, 2023

@ghost @bmuschko
Version 5.1.10 of the Gradle Artifactory plugin has just been released. In this release, we've made the transition from Gradle conventions to extensions. If you'd like to, please consider upgrading, and we'd love to hear your feedback on this update.

@bmuschko
Copy link

bmuschko commented Oct 4, 2023

Great, thanks! I am going to give it a try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants