Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the npx replacement #236

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Conversation

lishaduck
Copy link
Contributor

@lishaduck lishaduck commented Aug 29, 2024

There wasn't really consensus on the original issue, but I wanted to write some code, so πŸ€·β€β™‚οΈ
I improved the docs at least :)
For reference, the diff is -82 +82 lines, so it's literally a net neutral w/regard to maintainability.
It primarily does so by reusing existing code for emulating npx for elm-format instead of using another (hacky) handrolled solution I introduced in #197 (as a nice side effect, we test that the CLI works without --compiler in the unit tests again).

Closes #224.

@lishaduck lishaduck mentioned this pull request Aug 29, 2024
23 tasks
Copy link
Owner

@jfmengels jfmengels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

PS/heads-up: leaving on vacation for 1-2 weeks. I'll likely see the PRs but I won't have a laptop.

@jfmengels jfmengels merged commit 154855b into jfmengels:main Aug 30, 2024
3 checks passed
@lishaduck lishaduck deleted the local-elm branch August 31, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for locally installed binaries
2 participants