Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Tests (fix ci, enable typesafety, better unix/posix stuff, etc) #197

Merged
merged 11 commits into from
Aug 29, 2024

Conversation

lishaduck
Copy link
Contributor

Depends on: #196.
Split off from: #196.

Copy link
Owner

@jfmengels jfmengels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Interesting "going overboard" commit 😄

Can you resolve the conflicts? Then I'll merge the PR 👍

@lishaduck
Copy link
Contributor Author

lishaduck commented Jul 8, 2024

Interesting "going overboard" commit 😄

Function currying! (sort of) 😆
Yeah, that's the sort of thing I enjoy. Is it going to be needed, ever? No. Is it fun? Oh, yeah!

Sorry it took so long. Was scratching my head over why my local main wasn't syncing with jfmengels:main (had to sync them on the remote), then I had dinner.

@lishaduck
Copy link
Contributor Author

lishaduck commented Jul 9, 2024

Pingy ping :)
Rebased this one, @jfmengels

Oh, well I guess there've been some more, give me a minute.

@lishaduck
Copy link
Contributor Author

Here ya go!

Make the type system as smart as the function.
Currently skipping `elm-tooling.test.js`.
I was struggling to figure out why the tests failed in the editor, but passed in CI.
Now, they don't!
@lishaduck lishaduck requested a review from jfmengels July 17, 2024 18:20
@lishaduck lishaduck mentioned this pull request Aug 24, 2024
11 tasks
POSIX deprecated function, according to StackOverflow.
I like this style better anyway, so 🤷‍♂️
@lishaduck
Copy link
Contributor Author

lishaduck commented Aug 25, 2024

@jfmengels, can you merge this? I fixed all the CI errors, some stuff slipped through #193.

EDIT: Looks like it hit rate limits somehow, but it passes locally at least.

@lishaduck lishaduck changed the title Test typesafety Improve Tests (fix ci, enable typesafety, better unix/posix stuff, etc) Aug 25, 2024
@lishaduck
Copy link
Contributor Author

lishaduck commented Aug 25, 2024

I gave it 30 min, retrying ci (I finally found a way to not need a dummy commit to retrigger CI!).

@lishaduck
Copy link
Contributor Author

lishaduck commented Aug 25, 2024

Now Jest is failing... ’Twas a flake!

I'm this 🤌 close to rewriting the whole test suite 🤣

@lishaduck
Copy link
Contributor Author

lishaduck commented Aug 25, 2024

@jfmengels, ping :)

I want to get to fixing some other stuff tonight, but I'd rather get this merged first.
The clock widget says it's 11pm in Paris right now though, so if not, I get it :)

@lishaduck
Copy link
Contributor Author

@jfmengels, ping again :)
This is blocking me getting more work done here, so I'd like to land this/get a review soon.

If you're sick or work is busy or on vacation, or whatever, I can wait, this isn't that important.
I can see that you're not right online right now, so this probably won't get to you. If it does get to you, though, I finished the side project I was finishing before I circled back to elm-review, and I'd like to knock out #125 soon, but I'd prefer to wait for this to get merged first.
Thanks!

@jfmengels jfmengels merged commit 20bd482 into jfmengels:main Aug 29, 2024
3 checks passed
@jfmengels
Copy link
Owner

Hey @lishaduck, sorry for the delay! I simply missed your messages.

PS: I'm not on vacation, but will soon be (and without a laptop) for a week or two. I could probably still review and merge small-ish PRs, but expect limited responsiveness.

@lishaduck
Copy link
Contributor Author

Hey @lishaduck, sorry for the delay! I simply missed your messages.

It's fine :)

PS: I'm not on vacation, but will soon be (and without a laptop) for a week or two. I could probably still review and merge small-ish PRs, but expect limited responsiveness.

Sounds good! School's started back up, so I probably won't be making many mega-prs.

@lishaduck lishaduck deleted the test-typesafety branch August 29, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants