-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Tests (fix ci, enable typesafety, better unix/posix stuff, etc) #197
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Interesting "going overboard" commit 😄
Can you resolve the conflicts? Then I'll merge the PR 👍
b9d3f8f
to
b41f328
Compare
Function currying! (sort of) 😆 Sorry it took so long. Was scratching my head over why my local main wasn't syncing with jfmengels:main (had to sync them on the remote), then I had dinner. |
Pingy ping :) Oh, well I guess there've been some more, give me a minute. |
b41f328
to
62eac5d
Compare
Here ya go! |
Make the type system as smart as the function.
Currently skipping `elm-tooling.test.js`.
62eac5d
to
e5fbe4c
Compare
I was struggling to figure out why the tests failed in the editor, but passed in CI. Now, they don't!
POSIX deprecated function, according to StackOverflow. I like this style better anyway, so 🤷♂️
93c4759
to
b124749
Compare
@jfmengels, can you merge this? I fixed all the CI errors, some stuff slipped through #193. EDIT: Looks like it hit rate limits somehow, but it passes locally at least. |
b124749
to
8e86e5f
Compare
I gave it 30 min, retrying ci (I finally found a way to not need a dummy commit to retrigger CI!). |
I'm this 🤌 close to rewriting the whole test suite 🤣 |
@jfmengels, ping :) I want to get to fixing some other stuff tonight, but I'd rather get this merged first. |
@jfmengels, ping again :) If you're sick or work is busy or on vacation, or whatever, I can wait, this isn't that important. |
Hey @lishaduck, sorry for the delay! I simply missed your messages. PS: I'm not on vacation, but will soon be (and without a laptop) for a week or two. I could probably still review and merge small-ish PRs, but expect limited responsiveness. |
It's fine :)
Sounds good! School's started back up, so I probably won't be making many mega-prs. |
Depends on: #196.
Split off from: #196.