Issue #4737 Ensure lifecycle callbacks happen for run-as and non async servlets #4744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c servlets Signed-off-by: Jan Bartel <janb@webtide.com>
gregw
approved these changes
Apr 6, 2020
jetty-servlet/src/main/java/org/eclipse/jetty/servlet/ServletHolder.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Jan Bartel <janb@webtide.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4737
Need to unwrap RunAsServlet and NotAsyncServlet before calling ServletHandler.destroyServlet(Servlet) because these wrapper classnames are unknown outside of the ServletHolder, in particular to the LifeCycleCallbackCollection, which contains the maps of postConstruct and preDestroy methods to call based on the name of the class.