Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PreDestroy not called for non-async and run-as servlets #4737

Closed
janbartel opened this issue Apr 1, 2020 · 1 comment
Closed

PreDestroy not called for non-async and run-as servlets #4737

janbartel opened this issue Apr 1, 2020 · 1 comment
Assignees
@janbartel
Labels
Bug For general bugs on Jetty side

Comments

@janbartel
Copy link
Contributor

** jetty 9.4.21 and above **

Problem occurs since commit 39c230f.

Servlets that do not support async, or for which <run-as> has been set, will not have methods annotated with @PreDestroy called.
@janbartel janbartel added the Bug For general bugs on Jetty side label Apr 1, 2020
@janbartel janbartel self-assigned this Apr 1, 2020
janbartel added a commit that referenced this issue Apr 2, 2020
@janbartel
Issue #4737 Ensure lifecycle callbacks happen for run-as and non asyn…
19ea096 
…c servlets

Signed-off-by: Jan Bartel <janb@webtide.com>
@janbartel janbartel mentioned this issue Apr 2, 2020
Merged
janbartel added a commit that referenced this issue Apr 6, 2020
@janbartel
Issue #4737 change after review
0a0f4f0 
Signed-off-by: Jan Bartel <janb@webtide.com>
janbartel added a commit that referenced this issue Apr 6, 2020
@janbartel
Issue #4737 Ensure lifecycle callbacks happen for run-as and non asyn…
4b28422 
…c servlets (#4744)

* Issue #4737 Ensure lifecycle callbacks happen for run-as and non async servlets

Signed-off-by: Jan Bartel <janb@webtide.com>
@janbartel
Copy link
Contributor Author

Fixed for 9.4.28.

janbartel added a commit that referenced this issue Apr 6, 2020
@janbartel
Fix merge from 9.4 for #4737
f57a170
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@janbartel janbartel

Labels
Bug For general bugs on Jetty side
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@janbartel