Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure that a ServiceLoader is retrieved before iterating #10169

Merged

Conversation

RangerRick
Copy link

fixes #10168

@gregw
Copy link
Contributor

gregw commented Jul 28, 2023

@RangerRick thanks for the PR. As 9 is end of community support, we can't say if this will get merged or if it does if/when there will be another release.

However, for us to merge it, we would need the ECA to be signed. If you don't sign it, then we need to find a developer who has not seen your contribution to fix this issue (if we decided to do it).

@RangerRick
Copy link
Author

RangerRick commented Jul 28, 2023

@gregw yeah I figured it was a long shot, but it was worth submitting. Because of the interdependencies between karaf and pax and ourselves, moving to 10 is an ongoing project but in the meantime I'm trying to solve the race. :)

As for the ECA, I've signed it now, not sure how to make it re-check.

update aha! the "details" on the ECA failure took me to a page to re-validate. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NPE in websocket extension startup
3 participants