Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NMS-15345: clean up/refactor karaf dependencies to make startup more consistent #6472

Merged
merged 25 commits into from
Aug 16, 2023

Conversation

RangerRick
Copy link
Contributor

The intermittent issues with starting up flow-related code appears to be a race-condition in Karaf startup that can cause it to time out.

This branch does a number of things in an attempt to clean up the startup process:

  • move a number of karaf dependencies to their own features in the features-core.xml file and change anything using those dependencies to point to the features instead
  • define a set of common start levels and retarget some bundles to match those start levels
  • integrate (and override) a number of pax-web and jetty improvements to get rid of bloat and speed startup
  • clean up bouncycastle dependencies as much as possible
  • enable feature validation in the container/features project and validate a number of core and minion/sentinel features for proper dependency chains
  • create a jetty "noop" extension to work around a race condition in Jetty triggered by CXF's websocket startup, in case Jetty doesn't make another 9.4.x release
  • add Bundle-SymbolicName and Bundle-Version to all wrapped dependencies, to make the bundle list in karaf easier to understand

With these changes (especially start-level definitions and better dependencies) I have been unable to reproduce the flow startup issue, though that doesn't guarantee it's eliminated.

That said, these updates have value anyway and are worth merging to 2023 and up. While it looks like a lot of churn, it is (for the most part) just rearranging things that already existed. The only significant updates is the removal of JASPI bits from Jetty to align with pax-web 7.4 (we don't use them and they caused exceptions in the karaf logs anyway), and an update of versions for a number of commons-* projects and asm.

There is a Horizon 32 version of this branch that I will merge upon approval of this one. It only contains minor changes relating to slightly different dependencies (newts 3 and cassandra, most notably) but is functionally the same.

I won't merge until both are green.

External References

@RangerRick
Copy link
Contributor Author

RangerRick commented Aug 2, 2023

looks like the h32 version of this is passing smoke tests as well (it just needed some fixups related to the cassandra driver 3 -> 4 move), so I'm pretty confident this is in good shape and mergeable \o/

Copy link
Contributor

@cgorantla cgorantla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as we have covered enough with testing!

@RangerRick RangerRick merged commit 2e28516 into foundation-2023 Aug 16, 2023
3 of 4 checks passed
@RangerRick RangerRick deleted the jira/NMS-15345-telemetry-adapter-smoke branch August 16, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants