-
Notifications
You must be signed in to change notification settings - Fork 576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NMS-15345: clean up/refactor karaf dependencies to make startup more consistent #6472
Merged
RangerRick
merged 25 commits into
foundation-2023
from
jira/NMS-15345-telemetry-adapter-smoke
Aug 16, 2023
Merged
NMS-15345: clean up/refactor karaf dependencies to make startup more consistent #6472
RangerRick
merged 25 commits into
foundation-2023
from
jira/NMS-15345-telemetry-adapter-smoke
Aug 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…= overrides to use them
RangerRick
requested review from
fooker,
jeffgdotorg,
synqotik,
christianpape,
deejgregor,
cgorantla and
mershad-manesh
August 1, 2023 17:38
looks like the h32 version of this is passing smoke tests as well (it just needed some fixups related to the cassandra driver 3 -> 4 move), so I'm pretty confident this is in good shape and mergeable \o/ |
cgorantla
approved these changes
Aug 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as long as we have covered enough with testing!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intermittent issues with starting up flow-related code appears to be a race-condition in Karaf startup that can cause it to time out.
This branch does a number of things in an attempt to clean up the startup process:
features-core.xml
file and change anything using those dependencies to point to the features insteadcontainer/features
project and validate a number of core and minion/sentinel features for proper dependency chainsBundle-SymbolicName
andBundle-Version
to all wrapped dependencies, to make the bundle list in karaf easier to understandWith these changes (especially
start-level
definitions and better dependencies) I have been unable to reproduce the flow startup issue, though that doesn't guarantee it's eliminated.That said, these updates have value anyway and are worth merging to 2023 and up. While it looks like a lot of churn, it is (for the most part) just rearranging things that already existed. The only significant updates is the removal of JASPI bits from Jetty to align with pax-web 7.4 (we don't use them and they caused exceptions in the karaf logs anyway), and an update of versions for a number of commons-* projects and asm.
There is a Horizon 32 version of this branch that I will merge upon approval of this one. It only contains minor changes relating to slightly different dependencies (newts 3 and cassandra, most notably) but is functionally the same.
I won't merge until both are green.
External References