Check constructor equality in .toStrictEqual()

[ollelauribostrom]

Associated Issue: #6767

Summary

Modified typeEquality to check for constructor equality and not just compare constructor names. This makes .toStrictEqual() no longer treat different classes with the same name as equal.

Test plan

• Added a test case that verifies that .toStrictEqual() no longer treat different classes with the same name as equal.

[codecov-io]

Codecov Report

Merging #7005 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #7005   +/-   ##
=======================================
  Coverage   66.89%   66.89%           
=======================================
  Files         251      251           
  Lines       10488    10488           
  Branches        4        3    -1     
=======================================
  Hits         7016     7016           
  Misses       3471     3471           
  Partials        1        1

Impacted Files	Coverage Δ
packages/expect/src/utils.js	98.16% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 728ca11...6252af6. Read the comment docs.

[SimenB]

@emilsjolander mind taking a look?

@ollelauribostrom can you update the changelog?

[ollelauribostrom]

@SimenB Changelog updated ✔️

[thymikee]

LGTM

[rickhanlonii]

Seems reasonable to me, should this go in a minor?

[rickhanlonii]

Is there a test for when constructor.name is equal but the constructors are not?

[ollelauribostrom]

The last test case (Line 253, it('does not simply compare constructor names'..) should cover this if I'm not mistaken?

[rickhanlonii]

Ah yes, I see it now, thanks!

May be worth adding an expect like:

expect(c.constructor.name).toEqual(d.constructor.name);

[ollelauribostrom]

Added that, should make it a bit more clear

[SimenB]

should this go in a minor?

Next release is major, unless anyone wanna be fancy with cherry-picking etc.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.