Check constructor equality in .toStrictEqual()

jestjs · Sep 20, 2018 · 4e0a130 · 4e0a130
1 parent ee751bf
commit 4e0a130
Show file tree

Hide file tree

Showing 3 changed files with 32 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,7 @@
 
 - `[pretty-format]` Option to not escape strings in diff messages ([#5661](https://github.com/facebook/jest/pull/5661))
 - `[jest-haste-map]` Add `getFileIterator` to `HasteFS` for faster file iteration ([#7010](https://github.com/facebook/jest/pull/7010)).
+- `[expect]` Check constructor equality in .toStrictEqual() ([#7005](https://github.com/facebook/jest/pull/7005))
 
 ### Fixes
 

diff --git a/packages/expect/src/__tests__/matchers.test.js b/packages/expect/src/__tests__/matchers.test.js
@@ -205,13 +205,32 @@ describe('.toBe()', () => {
 });
 
 describe('.toStrictEqual()', () => {
-  class TestClass {
+  class TestClassA {
     constructor(a, b) {
       this.a = a;
       this.b = b;
     }
   }
 
+  class TestClassB {
+    constructor(a, b) {
+      this.a = a;
+      this.b = b;
+    }
+  }
+
+  const TestClassC = class Child extends TestClassA {
+    constructor(a, b) {
+      super(a, b);
+    }
+  };
+
+  const TestClassD = class Child extends TestClassB {
+    constructor(a, b) {
+      super(a, b);
+    }
+  };
+
   it('does not ignore keys with undefined values', () => {
     expect({
       a: undefined,
@@ -221,14 +240,20 @@ describe('.toStrictEqual()', () => {
 
   it('passes when comparing same type', () => {
     expect({
-      test: new TestClass(1, 2),
-    }).toStrictEqual({test: new TestClass(1, 2)});
+      test: new TestClassA(1, 2),
+    }).toStrictEqual({test: new TestClassA(1, 2)});
   });
 
   it('does not pass for different types', () => {
     expect({
-      test: new TestClass(1, 2),
-    }).not.toStrictEqual({test: {a: 1, b: 2}});
+      test: new TestClassA(1, 2),
+    }).not.toStrictEqual({test: new TestClassB(1, 2)});
+  });
+
+  it('does not simply compare constructor names', () => {
+    expect({
+      test: new TestClassC(1, 2),
+    }).not.toStrictEqual({test: new TestClassD(1, 2)});
   });
 });
 

diff --git a/packages/expect/src/utils.js b/packages/expect/src/utils.js
@@ -213,7 +213,7 @@ export const subsetEquality = (object: Object, subset: Object) => {
 };
 
 export const typeEquality = (a: any, b: any) => {
-  if (a == null || b == null || a.constructor.name === b.constructor.name) {
+  if (a == null || b == null || a.constructor === b.constructor) {
     return undefined;
   }