Fix "reporters: ['default']" config #3562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3562 +/- ##
=======================================
Coverage 62.39% 62.39%
=======================================
Files 181 181
Lines 6646 6646
Branches 6 6
=======================================
Hits 4147 4147
Misses 2496 2496
Partials 3 3
Continue to review full report at Codecov.
|
thymikee
approved these changes
May 16, 2017
| @@ -329,7 +329,7 @@ class TestRunner { | |||
|
|
|||
| _addCustomReporters(reporters: Array<ReporterConfig>) { | |||
| const customReporters = reporters.filter( | |||
| reporter => reporter !== 'default', | |||
| reporterConfig => reporterConfig[0] !== 'default', | |||
There was a problem hiding this comment.
Uuu, too bad Flow can't catch comparisons like that :/
orta
pushed a commit
to orta/jest
that referenced
this pull request
Jul 7, 2017
tushardhole
pushed a commit
to tushardhole/jest
that referenced
this pull request
Aug 21, 2017
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a "cannot find module" error when the reporters config includes the string "default" (the documented way to keep the default reporters enabled).
Test plan
Added new test.