TestRunner._addCustomReporter "default" filter is not working

[jonathanglasmeyer]

Do you want to request a feature or report a bug?
bug

What is the current behavior?
I specify custom reporters like so:

  "reporters": [
    "default",
    "<rootDir>/api/test/db-resetting-reporter.js"
  ],

Like the documentation explains. This fails with:

Determining test suites to run...Error: An error occured while adding the reporter at path "default".Cannot find module 'default'
    at customReporters.forEach (/Users/jwerner/mesaic/mesaic/node_modules/jest-cli/build/TestRunner.js:343:15)
    at Array.forEach (native)
    at TestRunner._addCustomReporters (/Users/jwerner/mesaic/mesaic/node_modules/jest-cli/build/TestRunner.js:336:21)
    at TestRunner._setupReporters (/Users/jwerner/mesaic/mesaic/node_modules/jest-cli/build/TestRunner.js:296:12)
    at new TestRunner (/Users/jwerner/mesaic/mesaic/node_modules/jest-cli/build/TestRunner.js:67:10)
    at /Users/jwerner/mesaic/mesaic/node_modules/jest-cli/build/runJest.js:202:27
    at Generator.next (<anonymous>)
    at step (/Users/jwerner/mesaic/mesaic/node_modules/jest-cli/build/runJest.js:10:198)
    at /Users/jwerner/mesaic/mesaic/node_modules/jest-cli/build/runJest.js:10:358
    at process._tickCallback (internal/process/next_tick.js:103:7)

What is the expected behavior?
Not to fail when i specify "default".

I think i also found the fix (start of TestRunner._addCustomReporter method)

const customReporters = reporters.filter(
-  reporter => reporter !== 'default'
+  ([reporter]) => reporter !== 'default'
);

The problem seems to be that reporters are normalized to the [moduleName, options] before, which is why the string format is not recognized correctly here.

Please provide your exact Jest configuration and mention your Jest, node, yarn/npm version and operating system.

❯ ./node_modules/.bin/jest -v
v20.0.1

[wyze]

Not sure if this is a duplicate of a previous issue, but there is a PR (#3562) in to fix this.

[jonathanglasmeyer]

Sweet, thanks for the pointer. Seems to be the exact issue!

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.