Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(consistent-test-it): false positives inside describe.each #782

Merged
merged 1 commit into from
Mar 7, 2021

Conversation

idan-at
Copy link
Contributor

@idan-at idan-at commented Mar 7, 2021

I think this PR added false positive ESLing errors where test inside describe.each was actually thought to be it inside describe.each. (and the other way around) - see failing tests.

The bug exists on the last release (24.1.7) but was not present before.

The fix was in the isDescribe and isTestCase helpers, which ignored the .each version with templates.

@SimenB SimenB requested a review from G-Rath March 7, 2021 11:40
Copy link
Collaborator

@G-Rath G-Rath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cheers!

@G-Rath G-Rath merged commit bdf6afe into jest-community:main Mar 7, 2021
@G-Rath
Copy link
Collaborator

G-Rath commented Mar 7, 2021

The title merged in to be greater than 100 chars - I've forcely re-worded it on main to be fix(consistent-test-it): support `it.each` in `describe.each` (#782)

@G-Rath
Copy link
Collaborator

G-Rath commented Mar 7, 2021

ugh seems the forces are coming together to prevent this one from being released:

⧗   input: chore(release): 24.1.8 [skip ci]

* **consistent-test-it:** support `it.each` in `describe.each` ([#782](https://github.com/jest-community/eslint-plugin-jest/issues/782)) ([0014da0](https://github.com/jest-community/eslint-plugin-jest/commit/0014da0e2aeb13199a9da7f969e9eb376e026c8b))
✖   footer's lines must not be longer than 100 characters [footer-max-line-length]

✖   found 1 problems, 0 warnings
ⓘ   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

@G-Rath
Copy link
Collaborator

G-Rath commented Mar 7, 2021

@SimenB I think this is because of #781 - in the past it doesn't look like husky/commitlint would run against the commits made by semantic-release.

github-actions bot pushed a commit that referenced this pull request Mar 7, 2021
## [24.1.8](v24.1.7...v24.1.8) (2021-03-07)

### Bug Fixes

* **consistent-test-it:** support `it.each` in `describe.each` ([#782](#782)) ([0014da0](0014da0))
This was referenced Mar 8, 2021
This was referenced Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants