Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: proper support for it.each #722

Merged
merged 2 commits into from
Mar 6, 2021
Merged

fix: proper support for it.each #722

merged 2 commits into from
Mar 6, 2021

Conversation

k-yle
Copy link
Contributor

@k-yle k-yle commented Nov 27, 2020

retrying #701, this time without the regression for no-done-callback 🙊

no-done-callback now works for jest-each's tagged-template syntax, but intentionally ignores it.each's table/array syntax because I have no idea how to handle this edge case.

@SimenB SimenB requested a review from G-Rath November 27, 2020 14:26
src/rules/no-disabled-tests.ts Outdated Show resolved Hide resolved
Co-authored-by: Gareth Jones <Jones258@Gmail.com>
@SimenB
Copy link
Member

SimenB commented Jan 5, 2021

@k-yle is this still draft?

@k-yle
Copy link
Contributor Author

k-yle commented Jan 5, 2021

sorry, it's ready @SimenB

I thought someone else might try to make it work for this edge case: #710 (comment) but it seems to be very hard

@SimenB SimenB marked this pull request as ready for review January 5, 2021 08:21
@SimenB
Copy link
Member

SimenB commented Jan 5, 2021

We can do that later 👍

@SimenB SimenB requested a review from G-Rath January 5, 2021 08:21
Copy link
Collaborator

@G-Rath G-Rath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the late review - looks good to me, lets ship it!

@G-Rath G-Rath merged commit e1dc42d into jest-community:master Mar 6, 2021
github-actions bot pushed a commit that referenced this pull request Mar 6, 2021
## [24.1.6](v24.1.5...v24.1.6) (2021-03-06)

### Bug Fixes

* proper support for it.each  ([#722](#722)) ([e1dc42d](e1dc42d))
@github-actions
Copy link

github-actions bot commented Mar 6, 2021

🎉 This PR is included in version 24.1.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@k-yle k-yle deleted the each branch March 6, 2021 19:21
This was referenced Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants