Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse unexported embedded option struct fields in Go 1.6 (consistent w/pre-Go 1.6) #156

Merged
merged 1 commit into from
Dec 22, 2015
Merged

Parse unexported embedded option struct fields in Go 1.6 (consistent w/pre-Go 1.6) #156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion group.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ func (g *Group) scanStruct(realval reflect.Value, sfield *reflect.StructField, h
field := stype.Field(i)

// PkgName is set only for non-exported fields, which we ignore
if field.PkgPath != "" {
if field.PkgPath != "" && !field.Anonymous {
continue
}

Expand Down
14 changes: 14 additions & 0 deletions parser_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,3 +471,17 @@ func TestChoices(t *testing.T) {
assertParseSuccess(t, &opts, "--choose", "v2")
assertString(t, opts.Choice, "v2")
}

func TestEmbedded(t *testing.T) {
type embedded struct {
V bool `short:"v"`
}
var opts struct {
embedded
}

assertParseSuccess(t, &opts, "-v")
if !opts.V {
t.Errorf("Expected V to be true")
}
}