Parse unexported embedded option struct fields in Go 1.6 (consistent w/pre-Go 1.6) #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w/pre-Go 1.6)
Pre-Go 1.6, the newly added TestEmbeddedUnexported test passes. In Go
1.6beta1, it fails:
```
$ go test
--- FAIL: TestEmbedded (0.00s)
assert_test.go:92: Unexpected parse error: unknown flag `v'
```
This commit makes the behavior consistent across Go versions.
Related: golang/go#12367, specifically the
comments about how "code that assumes `f.PkgPath != nil` means a field
is unexported and must be ignored must now be revised to check for
`f.PkgPath != nil && !f.Anonymous` for it to walk into the embedded
structs to look for exported fields contained within."
jessevdk
added a commit
that referenced
this pull request
Dec 22, 2015
Parse unexported embedded option struct fields in Go 1.6 (consistent w/pre-Go 1.6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Go 1.6, the newly added TestEmbeddedUnexported test passes. In Go 1.6beta1, it fails:
This commit makes the behavior consistent across Go versions.
Related: golang/go#12367, specifically the comments about how "code that assumes
f.PkgPath != nilmeans a field is unexported and must be ignored must now be revised to check forf.PkgPath != nil && !f.Anonymousfor it to walk into the embedded structs to look for exported fields contained within."