add image to conatiner view. #145
Conversation
Codecov Report
@@ Coverage Diff @@
## master #145 +/- ##
==========================================
- Coverage 26.12% 26.06% -0.07%
==========================================
Files 13 13
Lines 1129 1132 +3
==========================================
Hits 295 295
- Misses 821 824 +3
Partials 13 13
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #145 +/- ##
=========================================
- Coverage 26.12% 26.1% -0.03%
=========================================
Files 13 13
Lines 1129 1130 +1
=========================================
Hits 295 295
- Misses 821 822 +1
Partials 13 13
Continue to review full report at Codecov.
|
pkg/commands/container.go
Outdated
| @@ -248,7 +248,11 @@ type ContainerCliStat struct { | |||
|
|
|||
| // GetDisplayStrings returns the dispaly string of Container | |||
| func (c *Container) GetDisplayStrings(isFocused bool) []string { | |||
| return []string{c.GetDisplayStatus(), c.Name, c.GetDisplayCPUPerc()} | |||
| image := c.Container.Image | |||
There was a problem hiding this comment.
we can just do image := strings.TrimPrefix(c.Container.Image, "sha256:") here
There was a problem hiding this comment.
Since the image name may remain too long, I have just reserved 14 characters here.
There was a problem hiding this comment.
Compare with this one which is more concise and won't take much spaces.
There was a problem hiding this comment.
I personally don't mind if the image name is long, given we don't yet have any other columns to the right, and the magenta color means it's not too jarring on the eyes. But if you want to shorten it, I would add an ellipsis (...) after the 14 characters to communicate to the user that there's more of the image name not being shown
There was a problem hiding this comment.
I think long name is not very good. But I do think that add an ellipsis after the 14 characters is better than before. I'm going to do it.
There was a problem hiding this comment.
If I do that, it would be inconsistent with those named containers whose name is very long and with the other colums such as container name.
It may not be that bad to remain the whole name since there's no colums to the right now.
Though, I think it could be adjusted in the future when adding toggle-able expanded side panel view.
There was a problem hiding this comment.
So I'll adopt your suggestions that remain the whole name after sha256:
There was a problem hiding this comment.
@jesseduffield all is done. thank you.
Update issue: jesseduffield#144 Co-Authored-By: Jesse Duffield <jessedduffield@gmail.com>
|
Merged! Thanks for making this :) |
Fix: #144