Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add image name to container frame #144

Closed
anjiawei1991 opened this issue Aug 2, 2019 · 5 comments · Fixed by #145
Closed

add image name to container frame #144

anjiawei1991 opened this issue Aug 2, 2019 · 5 comments · Fixed by #145
Labels
enhancement New feature or request

Comments

@anjiawei1991
Copy link

2019-08-02 10-15-14屏幕截图

I think the image name should be added to the container frame because it's a really important thing especially when I haven't named the container such as the nice_cartwright and angry_chatterjee in the above picture. And, I can't see the image name in any of the right pages.

@anjiawei1991 anjiawei1991 added the enhancement New feature or request label Aug 2, 2019
@anjiawei1991
Copy link
Author

2019-08-02 10-57-23屏幕截图

I have done that job, and it looks nice I think.

anjiawei1991 pushed a commit to anjiawei1991/lazydocker that referenced this issue Aug 2, 2019
@mjarkk
Copy link
Contributor

mjarkk commented Aug 2, 2019

Have you also tried looking at it in a small terminal window?
I think the 0.00% is going to out of the window, and the cpu usage is for me more important than the image names.

The problem with these wide lines is that not everyone has there terminal maximized and for those these these changes look wrong.
For example when i start lazydocker these changes will look like this:

|running nice_cartwright  fortu|
|created angry_chatterjee f14d3|
|running nsq_nsqd_1       nsqio| <- this container name is now completly useless because i only see the username of who made the container

-> compaired to this
|running nice_cartwright  0.14%|
|created angry_chatterjee 0.00%|
|running nsq_nsqd_1       5.50%|

@anjiawei1991
Copy link
Author

2019-08-02 15-05-55屏幕截图

@mjarkk It works well if window's width is greater than 1150. CPU is indeed important. So another way is to place the image name behind the CPU. Or more sophisticated, decide wether to show the image name depend on the window's size, but it will bring complexity.

But I do think the image name is very important. I always use the terminal in max window size mode, and I think most of users do this.

@jesseduffield
Copy link
Owner

I've got no issue with showing the image name after the cpu.

Although, it seems that there is a strong use case for being able to see a lot of things related to a panel list item in the side panel. Perhaps we should consider having a toggle-able expanded side panel view for when you want to see extra information about all your e.g. containers at once.

At any rate for this issue I'm happy for the image name to go after the cpu.

@anjiawei1991
Copy link
Author

@jesseduffield
It sounds good to have a toggle-able expanded side panel view and that could be another issue.

I think I can change my codes and fix this one: show the image name after the CPU.

anjiawei1991 pushed a commit to anjiawei1991/lazydocker that referenced this issue Aug 3, 2019
anjiawei1991 pushed a commit to anjiawei1991/lazydocker that referenced this issue Aug 6, 2019
Update issue: jesseduffield#144

Co-Authored-By: Jesse Duffield <jessedduffield@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants