Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress warnings for spotbugs 4.8.3 #833

Merged
merged 4 commits into from
Jan 16, 2024
Merged

Suppress warnings for spotbugs 4.8.3 #833

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5f3edfd
Suppress two more warnings for spotbugs 4.8.3
MarkEWaite Jan 15, 2024
4faceab
Change justification to "too late"
MarkEWaite Jan 16, 2024
0720fe3
Change justification to TODO
MarkEWaite Jan 16, 2024
db9c781
Use parent pom 4.77
MarkEWaite Jan 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/src/main/java/com/cloudbees/groovy/cps/impl/NotBlock.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ public Next receive(Object o) {
return new ContinuationImpl(e, k).then(b, e, cast);
}

@SuppressFBWarnings(value = "SIC_INNER_SHOULD_BE_STATIC", justification = "Too late to fix compatibly.")
class ContinuationImpl extends ContinuationGroup {
final Continuation k;
final Env e;
Expand Down
1 change: 1 addition & 0 deletions plugin/src/main/java/org/jenkinsci/plugins/workflow/cps/CpsFlowExecution.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,6 +267,7 @@
*
* @see #runInCpsVmThread(FutureCallback)
*/
@SuppressFBWarnings(value = "PA_PUBLIC_PRIMITIVE_ATTRIBUTE", justification = "TODO clean up")

Check warning on line 270 in plugin/src/main/java/org/jenkinsci/plugins/workflow/cps/CpsFlowExecution.java

View check run for this annotation

ci.jenkins.io / Open Tasks Scanner

TODO 

NORMAL:
clean up")
public transient volatile ListenableFuture<CpsThreadGroup> programPromise;
private transient volatile Collection<ListenableFuture<?>> pickleFutures;

Expand Down
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<parent>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>plugin</artifactId>
<version>4.76</version>
<version>4.77</version>
<relativePath/>
</parent>
<groupId>org.jenkins-ci.plugins.workflow</groupId>
Expand Down
Loading