-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suppress warnings for spotbugs 4.8.3 #833
Suppress warnings for spotbugs 4.8.3 #833
Conversation
Will be needed with parent pom 4.77.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/jenkinsci/plugin-pom/releases/tag/plugin-4.77 is already out so I guess this should just switch to it?
plugin/src/main/java/org/jenkinsci/plugins/workflow/cps/CpsFlowExecution.java
Outdated
Show resolved
Hide resolved
so that is really a bug…but not one that we can fix compatibly now (since builds may be running across the upgrade). Co-authored-by: Jesse Glick <jglick@cloudbees.com>
Co-authored-by: Jesse Glick <jglick@cloudbees.com>
https://github.com/jenkinsci/plugin-pom/releases/tag/plugin-4.77 describes the changes in the 4.77 release of the parent pom. Those changes include: * jenkinsci/plugin-pom#880 - test harness update * jenkinsci/plugin-pom#884 - spotbugs plugin update Other dependencies were also updated in that parent pom.
Done in db9c781 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙇
Suppress warnings for spotbugs 4.8.3
Will be needed with parent pom 4.77.
Testing done
Confirmed that the spotbugs warnings are visible when using the 4.77-SNAPSHOT plugin pom before this change. With this change, the spotbugs warnings are no longer visible.
Submitter checklist