Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress warnings for spotbugs 4.8.3 #833

Merged
merged 4 commits into from
Jan 16, 2024

Conversation

MarkEWaite
Copy link
Contributor

@MarkEWaite MarkEWaite commented Jan 15, 2024

Suppress warnings for spotbugs 4.8.3

Will be needed with parent pom 4.77.

Testing done

Confirmed that the spotbugs warnings are visible when using the 4.77-SNAPSHOT plugin pom before this change. With this change, the spotbugs warnings are no longer visible.

Submitter checklist

Preview Give feedback

Will be needed with parent pom 4.77.
@MarkEWaite MarkEWaite requested a review from a team as a code owner January 15, 2024 19:49
@MarkEWaite MarkEWaite changed the title Suppress two more warnings for spotbugs 4.8.3 Suppress warnings for spotbugs 4.8.3 Jan 16, 2024
Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/jenkinsci/plugin-pom/releases/tag/plugin-4.77 is already out so I guess this should just switch to it?

MarkEWaite and others added 3 commits January 16, 2024 13:09
so that is really a bug…but not one that we can 
fix compatibly now (since builds may be running 
across the upgrade).

Co-authored-by: Jesse Glick <jglick@cloudbees.com>
Co-authored-by: Jesse Glick <jglick@cloudbees.com>
https://github.com/jenkinsci/plugin-pom/releases/tag/plugin-4.77 describes
the changes in the 4.77 release of the parent pom.  Those changes include:

* jenkinsci/plugin-pom#880 - test harness update
* jenkinsci/plugin-pom#884 - spotbugs plugin update

Other dependencies were also updated in that parent pom.
@MarkEWaite
Copy link
Contributor Author

https://github.com/jenkinsci/plugin-pom/releases/tag/plugin-4.77 is already out so I guess this should just switch to it?

Done in db9c781

Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇

@jglick jglick added the dependencies Pull requests that update a dependency file label Jan 16, 2024
@jglick jglick enabled auto-merge January 16, 2024 20:14
@jglick jglick merged commit 977bbfb into jenkinsci:master Jan 16, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants