-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility with JEP-227 #40
Conversation
Co-authored-by: Jesse Glick <jglick@cloudbees.com>
…nsulated from a release of jenkinsci/ldap-plugin#49
@bvcelari confirms that this patch works in 2.249.2 with an LDAP configuration. Has not been tested against a Spring-based core except to the extent that the simple functional test (not using LDAP) passes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code reviewed, not tested. It seems to cover well the changes from "groovy" to regular Java construction :)
I will close #38 as well, thanks!
Attempts to allow this plugin to run before or after JEP-227, analogous to jenkinsci/ldap-plugin#46 + jenkinsci/ldap-plugin#48.
Subsumes #38 for cleanup.
@Wadeck @oleg-nenashev @rsandell