Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-74800] Reverse Proxy Auth plugin 1.7.7 fails with 2.479.1 #147

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

basil
Copy link
Member

@basil basil commented Nov 1, 2024

Testing done

mvn clean verify

@basil basil added the bug label Nov 1, 2024
@basil basil requested a review from a team as a code owner November 1, 2024 21:41
Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following up #40.

@mpalourdio
Copy link

mpalourdio commented Nov 2, 2024

That's neat, we were spotted by he same bug and had began migrating to Spring 6, but had hard times with some methods that do not exist anymore (LdapUserDetails#getAttributes).Your implementation is much better, as I have no XP in jenkins plugin API, and Spring-LDAP is kinda meh :|

master...mpalourdio:reverse-proxy-auth-plugin:spring6

@basil
Copy link
Member Author

basil commented Nov 3, 2024

@mpalourdio Can you test the incremental build and let me know how it works? I don't actually use this plugin in production and have done only light testing. I haven't tested the header groups feature, so I would appreciate if someone could test that.

@mpalourdio
Copy link

AFAIK, the header groups feature has never landed in production, it's in master for a while, but never released. Will give this a shot early next week.

@sboardwell
Copy link
Contributor

thanks @basil and @mpalourdio for the changes and testing here.

@mpalourdio
Copy link

@basil I have just tested locally, the Assert bug is OK now. Our configuration includes a mix of HTTP headers for identification, and LDAP for groups to assign to jobs. Looks ok for me for those points.

@basil basil merged commit 2cd5c7a into jenkinsci:master Nov 5, 2024
18 checks passed
@basil basil deleted the JENKINS-74800 branch November 5, 2024 17:48
@basil
Copy link
Member Author

basil commented Nov 5, 2024

@mpalourdio Thanks!

@basil
Copy link
Member Author

basil commented Nov 5, 2024

@sboardwell Are you interested in performing a release? That would provide relief to any affected user(s).

@sboardwell
Copy link
Contributor

@basil I could do it either tonight or tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants