Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show full display name for runs in promoted build parameters #116

Merged
merged 3 commits into from
Jun 4, 2018
Merged

Show full display name for runs in promoted build parameters #116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e4c59ac
Updated promoted build parameter view
alhafoudh Apr 10, 2018
d112aa2
Show run's full display name in PromotedBuildParameterValue
dwnusbaum Jun 1, 2018
4410d2d
Merge pull request #1 from dwnusbaum/fullDisplayName
alhafoudh Jun 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...es/hudson/plugins/promoted_builds/parameters/PromotedBuildParameterDefinition/index.jelly
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,9 @@ THE SOFTWARE.
<input type="hidden" name="name" value="${it.name}" />
<select name="runId">
<j:forEach var="run" items="${it.builds}">
<option value="${run.externalizableId}">${run}</option>
<option value="${run.externalizableId}">${run.fullDisplayName}</option>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you really want fullDisplayName, which will include all parent folders/jobs ("Folder » SubFolder » Job $BuildDisplayName"), or just displayName, which would be either "Job #NUM" or the build's modified display name in your case?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went with fullDisplayName because jenkins parameters use that. In fact I need modified display name :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I will look around to see which seems more consistent across Jenkins, but other than that this PR seems totally fine to me, so I will try to merge+release it in the next week or so. Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to contribute :)

</j:forEach>
</select>
</div>
</f:entry>
</j:jelly>
</j:jelly>
2 changes: 1 addition & 1 deletion ...sources/hudson/plugins/promoted_builds/parameters/PromotedBuildParameterValue/value.jelly
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ THE SOFTWARE.
xmlns:i="jelly:fmt" xmlns:p="/lib/hudson/project">
<f:entry title="${it.name}" description="${it.description}">
<div name="parameter">
<a href="${rootURL}/${it.run.url}">${it.run}</a>
<a href="${rootURL}/${it.run.url}">${it.run.fullDisplayName}</a>
<input type="hidden" name="name" value="${it.name}" />
<input type="hidden" name="runId" value="${it.run.externalizableId}" />
</div>
Expand Down