Show full display name for runs in promoted build parameters #116
Conversation
Now promoted build parameter view displays full run name
|
In my workflow the build name is modified. It would be very handy to include the modified name as run parameter does |
| @@ -31,9 +31,9 @@ THE SOFTWARE. | |||
| <input type="hidden" name="name" value="${it.name}" /> | |||
| <select name="runId"> | |||
| <j:forEach var="run" items="${it.builds}"> | |||
| <option value="${run.externalizableId}">${run}</option> | |||
| <option value="${run.externalizableId}">${run.fullDisplayName}</option> | |||
There was a problem hiding this comment.
Do you really want fullDisplayName, which will include all parent folders/jobs ("Folder » SubFolder » Job $BuildDisplayName"), or just displayName, which would be either "Job #NUM" or the build's modified display name in your case?
There was a problem hiding this comment.
I went with fullDisplayName because jenkins parameters use that. In fact I need modified display name :)
There was a problem hiding this comment.
Ok, I will look around to see which seems more consistent across Jenkins, but other than that this PR seems totally fine to me, so I will try to merge+release it in the next week or so. Thanks!
There was a problem hiding this comment.
Glad to contribute :)
Show run's full display name in PromotedBuildParameterValue
dwnusbaum
changed the title
|
Yay! |
|
@alhafoudh Thanks for the PR! It is included in version 3.2 which I just released and should be available via the update center within a few hours. |
|
Thanks!
S pozdravom,
…--
Ahmed Al Hafoudh
CEO
Mobile: +421 918 341 216
Email: alhafoudh@freevision.sk
Web: www.freevision.sk
On 4 Jun 2018, at 21:25, Devin Nusbaum ***@***.***> wrote:
@alhafoudh <https://github.com/alhafoudh> Thanks for the PR! It is included in version 3.2 which I just released and should be available via the update center within a few hours.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#116 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AACphbVXSDIcbx1Wozkv4EAvVCIsim5Tks5t5YmhgaJpZM4TOGLh>.
|
Now promoted build parameter view displays full run name