Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to a BOM #134

Merged
merged 3 commits into from
Jul 30, 2019
Merged

Switch to a BOM #134

merged 3 commits into from
Jul 30, 2019

Conversation

jglick
Copy link
Member

@jglick jglick commented Jul 30, 2019

May as a side effect fix a PCT failure reported by @bmunozm, probably caused by mismatch between workflow-support versions in primary and tests classifier:

java.io.IOException: Pipeline: Groovy version 2.71 failed to load.
 - Pipeline: Supporting APIs version 2.17 is older than required. To fix, install version 3.3 or later.

Copy link
Member

@batmat batmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

K8s Plugin is already updated to BOM in the new release, so I have no problem with that

@jglick
Copy link
Member Author

jglick commented Jul 30, 2019

One test failure just needs a merge of #133. The other is

org.junit.ComparisonFailure: 
expected:<test key[]> but was:<test key[
]>
	at org.junit.Assert.assertEquals(Assert.java:115)
	at org.junit.Assert.assertEquals(Assert.java:144)
	at hudson.plugins.mercurial.HgExeFunctionalTest.credentialsSSHKeyTest(HgExeFunctionalTest.java:102)

which I presume is just picking up jenkinsci/ssh-credentials-plugin#33.

@jglick jglick merged commit 034aa28 into jenkinsci:master Jul 30, 2019
@jglick jglick deleted the bom branch July 30, 2019 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants