Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not rely on URL.equals in a test #133

Merged
merged 1 commit into from
Jul 30, 2019
Merged

Do not rely on URL.equals in a test #133

merged 1 commit into from
Jul 30, 2019

Conversation

jglick
Copy link
Member

@jglick jglick commented Jul 30, 2019

Observed in PCT runs:

java.lang.AssertionError: wrong url expected: java.net.URL<http://bitbucket.org/> but was: java.net.URL<http://bitbucket.org/>
	at org.junit.Assert.fail(Assert.java:88)
	at org.junit.Assert.failNotEquals(Assert.java:834)
	at org.junit.Assert.assertEquals(Assert.java:118)
	at hudson.plugins.mercurial.browser.HgBrowserSelectionTest.browsersAvailableInDropDown(HgBrowserSelectionTest.java:51)

presumably since this host maps to multiple IPs. CC @bmunozm

@jglick jglick added the test label Jul 30, 2019
@jglick jglick merged commit 3dc57e5 into jenkinsci:master Jul 30, 2019
@jglick jglick deleted the HgBrowserSelectionTest branch July 30, 2019 15:08
@jglick jglick mentioned this pull request Jul 30, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fcojfernandez fcojfernandez fcojfernandez approved these changes

@batmat batmat batmat approved these changes

@oleg-nenashev oleg-nenashev Awaiting requested review from oleg-nenashev

@alecharp alecharp Awaiting requested review from alecharp

Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jglick @batmat @fcojfernandez