Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-73046] Remove ASM from core #9182

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

jonesbusy
Copy link
Contributor

@jonesbusy jonesbusy commented Apr 20, 2024

Remove ASM dependencies now that most popular plugin are linked against: https://plugins.jenkins.io/asm-api/dependencies/

See JENKINS-73046.

See also https://groups.google.com/g/jenkinsci-dev/c/NhV_o6zxbzw

Initially opened on #9041

Now that we started a new LTS cycle on 2.452 it's probably the best moment for such PR

Testing done

Proposed changelog entries

  • Remove ASM dependencies from core.

Proposed upgrade guidelines

Upgrade all plugin to latest version before upgrading Jenkins core

Submitter checklist

Desired reviewers

@basil

Before the changes are marked as ready-for-merge:

Maintainer checklist

Copy link

welcome bot commented Apr 20, 2024

Yay, your first pull request towards Jenkins core was created successfully! Thank you so much!

A contributor will provide feedback soon. Meanwhile, you can join the chats and community forums to connect with other Jenkins users, developers, and maintainers.

@jonesbusy jonesbusy changed the title JENKINS-73046 Remove ASM from core [JENKINS-73046] Remove ASM from core Apr 20, 2024
@NotMyFault NotMyFault requested a review from basil April 20, 2024 07:16
@NotMyFault NotMyFault added the removed This PR removes a feature or a public API label Apr 20, 2024
Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@NotMyFault
Copy link
Member

/label ready-for-merge


This PR is now ready for merge. We will merge it after ~24 hours if there is no negative feedback.
Please see the merge process documentation for more information about the merge process.
Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Apr 21, 2024
@NotMyFault NotMyFault merged commit 0eb219e into jenkinsci:master Apr 22, 2024
16 checks passed
Copy link

welcome bot commented Apr 22, 2024

Congratulations on getting your very first Jenkins core pull request merged 🎉🥳

This is a fantastic achievement, and we're thrilled to have you as part of our community! Thank you for your valuable input, and we look forward to seeing more of your contributions in the future!

We would like to invite you to join the community chats and forums to meet other Jenkins contributors 😊
Don't forget to check out the participation page to learn more about how to contribute to Jenkins.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback removed This PR removes a feature or a public API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants