Test Jenkins weekly 2.477-rc35351.239ced05a_fca_

[MarkEWaite]

Test Jenkins weekly 2.477-rc35351.239ced05a_fca_

7ff5aaa0 is the most recent commit included in the build.

Script security plugin test failure fix is being proposed as:

• Fix JenkinsWhitelistTest on 2.477 incremental script-security-plugin#578

Blue ocean will need to be adapted to JGit 7.0.0. Pull request being proposed is:

• [JENKINS-73775] Replace deprecated call to JGit setLastModified(long) blueocean-plugin#2572
• [JENKINS-73775] Replace call to removed CommitBuilder.setEncoding(String) blueocean-plugin#2578 (merged but not released)

Analysis model API plugin reverted in this test pull request. That is tracked as:

• JENKINS-73776 - Plugin BOM tests fail with analysis model API 12.5.0

Testing done

Ran InjectedTest with git client plugin and confirmed it passed.

Submitter checklist

• Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
• Ensure that the pull request title represents the desired changelog entry
• Please describe what you did
• Link to relevant issues in GitHub or Jira
• Link to relevant pull requests, esp. upstream and downstream changes
• Ensure you have provided tests - that demonstrates feature works or fixes the issue

[MarkEWaite]

@uhafner I don't understand the test failures from the analysis model API plugin 12.5.0 release. They seem to be connected to a message that says:

WARNING	h.m.AbstractBuild$AbstractBuildExecution#reportError: Step ‘Record compiler warnings and static analysis results’ aborted 
due to exception: 
java.lang.IncompatibleClassChangeError: class org.objectweb.asm.tree.ClassNode has interface org.objectweb.asm.ClassVisitor as super class

Could you investigate to see if you can identify the root cause of the issue?

I can duplicate the issue from this pull request locally after I revert the downgrade of analysis-model-api with the command:

LINE=weekly PLUGINS=warnings-ng TEST=MatrixJobITest bash local-test.sh

The set of all test failures can be duplicated with (in case that is helpful):

LINE=weekly PLUGINS=warnings-ng TEST=MatrixJobITest,MiscIssuesRecorderITest,PackageDetectorsITest,ParsersITest,RemoteApiITest bash local-test.sh

[uhafner]

I will check. In the latest release I replaced my dependency to asm with the asm-api plugin. Maybe this change is not compatible?

[MarkEWaite]

I will check. In the latest release I replaced my dependency to asm with the asm-api plugin. Maybe this change is not compatible?

I think that asm API is related. Does the analysis model API plugin 12.5.0 depend on asm API 9.7-33.v4d23ef79fcc8? That is the version included in the plugin bom.

Answering my question: The Maven dependency tree shows that the asm-api version in analysis-model-api 12.5.0 is 9.7-33.v4d23ef79fcc8 and that is the same as is included in the plugin BOM.

[MarkEWaite]

I've submitted JENKINS-73776 to track the issue. Thanks in advance for your investigation @uhafner !

[uhafner]

Maybe the problem is, that the warnings plugin does not yet depend on anlysis-model 12.5.0 yet?

[MarkEWaite]

Maybe the problem is, that the warnings plugin does not yet depend on anlysis-model 12.5.0 yet?

That is a very good idea. Is there an incremental build of the warnings plugin that depends on analysis model 12.5.0?

[uhafner]

Not yet, but soon:

jenkinsci/warnings-ng-plugin#1824

[MarkEWaite]

Last change was incorrect

[basil]

I will check. In the latest release I replaced my dependency to asm with the asm-api plugin. Maybe this change is not compatible?

@uhafner ASM was not removed from Jenkins core until jenkinsci/jenkins#9182 in 2.455 (2.462.1 LTS), so using the ASM library plugin with older baselines will create conflicts between the ASM provided by the library plugin and the ASM provided by Jenkins core. I would recommend reverting the change to use the ASM library plugin until your baseline is 2.462.1 LTS or later.