Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop dependency on JavaSpecificationVersion introduced in version-number 1.6, newer than our core baseline #128

Merged
merged 1 commit into from
Apr 2, 2019

Conversation

jglick
Copy link
Member

@jglick jglick commented Apr 2, 2019

Amends #126 to avoid the need to pick up jenkinsci/lib-version-number#11. See jenkinsci/plugin-pom#175 (comment).

@jglick jglick requested review from batmat and oleg-nenashev April 2, 2019 17:04
jglick added a commit to jglick/plugin-pom that referenced this pull request Apr 2, 2019
Copy link
Member

@batmat batmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think it makes sense to indeed always/only take it from the Core. It was my mistake.

@jglick jglick merged commit f4b6b7c into jenkinsci:master Apr 2, 2019
@jglick jglick deleted the JavaSpecificationVersion branch April 2, 2019 19:16
@jglick jglick mentioned this pull request Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants