Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added JenkinsRule.showAgentLogs utility #127

Merged
merged 3 commits into from
Apr 2, 2019
Merged

Added JenkinsRule.showAgentLogs utility #127

merged 3 commits into from
Apr 2, 2019

Conversation

jglick
Copy link
Member

@jglick jglick commented Apr 2, 2019

Developed during JEP-210 work but could be broadly useful.

jglick added a commit to jglick/plugin-pom that referenced this pull request Apr 2, 2019
@jglick
Pick up jenkinsci/jenkins-test-harness#127 + jenkinsci/jenkins-test-h…
002f131 
…arness#128.
This was referenced Apr 2, 2019
Merged
Merged
batmat
batmat previously requested changes Apr 2, 2019
View reviewed changes
Copy link
Member

@batmat batmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great feature!

Just requesting change for the method name adjustment.

Thanks

src/main/java/org/jvnet/hudson/test/JenkinsRule.java Outdated Show resolved Hide resolved
@jglick jglick requested a review from batmat April 2, 2019 19:15
batmat
batmat approved these changes Apr 2, 2019
View reviewed changes
Copy link
Member

@batmat batmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@jglick jglick changed the title Added JenkinsRule.showSlaveLogs utility Added JenkinsRule.showAgentLogs utility Apr 2, 2019
@jglick jglick merged commit bc4dc8b into jenkinsci:master Apr 2, 2019
@jglick jglick deleted the showSlaveLogs branch April 2, 2019 19:33
jglick added a commit to jglick/jenkins that referenced this pull request Apr 2, 2019
@jglick
Picking up release of jenkinsci/jenkins-test-harness#127.
9ed1168
@jglick jglick mentioned this pull request Jul 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@batmat batmat batmat approved these changes

@oleg-nenashev oleg-nenashev Awaiting requested review from oleg-nenashev

@carlossg carlossg Awaiting requested review from carlossg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jglick @batmat