Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add trim for descriptionPropertyValue #100

Merged
merged 1 commit into from
Aug 6, 2023
Merged

add trim for descriptionPropertyValue #100

merged 1 commit into from
Aug 6, 2023

Conversation

mamh2021
Copy link
Contributor

@mamh2021 mamh2021 commented Aug 6, 2023 •
edited
Loading

try to fix #81

for selectContent.jelly <j:forEach var="value" items="${effectiveValue}"> this will be trim by jelly tag forEach.

for computeDefaultValue this will be trim by method computeDefaultValueMap

but descriptionPropertyValue was not trim.

Change-Id: Ic05be1679436d7c6c80c4d585a301acfbeaa5cc7

Testing done

Submitter checklist
Preview Give feedback

add trim for descriptionPropertyValue
b80d08f 
try to fix jenkinsci#81

for selectContent.jelly  <j:forEach var="value" items="${effectiveValue}"> this will be trim by jelly tag forEach.

for computeDefaultValue this will be trim by method computeDefaultValueMap

but descriptionPropertyValue was not trim.

Change-Id: Ic05be1679436d7c6c80c4d585a301acfbeaa5cc7
@mamh2021 mamh2021 requested a review from a team as a code owner August 6, 2023 00:51
@chonton chonton added the fix Pull request to fix an issue label Aug 6, 2023
@chonton chonton merged commit 2e02857 into jenkinsci:main Aug 6, 2023
mamh2021 pushed a commit to mamh-java/extended-choice-parameter-plugin that referenced this pull request Nov 5, 2023
add trim for descriptionPropertyValue (jenkinsci#100)
95bc8f2 
try to fix jenkinsci#81

for selectContent.jelly  <j:forEach var="value" items="${effectiveValue}"> this will be trim by jelly tag forEach.

for computeDefaultValue this will be trim by method computeDefaultValueMap

but descriptionPropertyValue was not trim.

Change-Id: Ic05be1679436d7c6c80c4d585a301acfbeaa5cc7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fix Pull request to fix an issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

effectiveValue always auto strip whitespace for each item
2 participants
@mamh2021 @chonton