Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

effectiveValue always auto strip whitespace for each item #81

Closed
mamh2021 opened this issue Mar 11, 2023 · 1 comment · Fixed by #100
Closed

effectiveValue always auto strip whitespace for each item #81

mamh2021 opened this issue Mar 11, 2023 · 1 comment · Fixed by #100

Comments

@mamh2021
Copy link
Contributor

mamh2021 commented Mar 11, 2023 •
edited
Loading

Jenkins and plugins versions report

for selectContent.jelly <j:forEach var="value" items="${effectiveValue}">

ParameterDefinitionInfo.effectiveValue always auto strip whitespace in forEach tag, so it will not match value to description

value is 111,22222 ,3333,444444

description is aaa,bbb,ccc,ddd

in computeDefaultValueMap method defaultValues always trim

in computeDescriptionPropertyValueMap method , the map keys not were trim

so I suggest make the three to same strategy

What Operating System are you using (both controller, and any agents involved in the problem)?

extended-choice-parameter-plugin with the lastest source code at df7ecf9 * Update pom.xml

Reproduction steps

select "Basic Parameter Types"
set value to 111,22222 ,3333,444444
set description to aaa,bbb,ccc,ddd
image

Expected Results

image

Actual Results

image

image

Anything else?

No response
@chonton
Copy link
Collaborator

chonton commented Apr 23, 2023

Pull requests are welcome

mamh2021 pushed a commit to mamh-java/extended-choice-parameter-plugin that referenced this issue Aug 6, 2023
add trim for descriptionPropertyValue
b80d08f 
try to fix jenkinsci#81

for selectContent.jelly  <j:forEach var="value" items="${effectiveValue}"> this will be trim by jelly tag forEach.

for computeDefaultValue this will be trim by method computeDefaultValueMap

but descriptionPropertyValue was not trim.

Change-Id: Ic05be1679436d7c6c80c4d585a301acfbeaa5cc7
@mamh2021 mamh2021 mentioned this issue Aug 6, 2023
Merged
chonton pushed a commit that referenced this issue Aug 6, 2023
@mamh2021
add trim for descriptionPropertyValue (#100)
2e02857 
try to fix #81

for selectContent.jelly  <j:forEach var="value" items="${effectiveValue}"> this will be trim by jelly tag forEach.

for computeDefaultValue this will be trim by method computeDefaultValueMap

but descriptionPropertyValue was not trim.

Change-Id: Ic05be1679436d7c6c80c4d585a301acfbeaa5cc7

Co-authored-by: bright.ma <bright.ma@magesfc.com>
mamh2021 pushed a commit to mamh-java/extended-choice-parameter-plugin that referenced this issue Nov 5, 2023
add trim for descriptionPropertyValue (jenkinsci#100)
95bc8f2 
try to fix jenkinsci#81

for selectContent.jelly  <j:forEach var="value" items="${effectiveValue}"> this will be trim by jelly tag forEach.

for computeDefaultValue this will be trim by method computeDefaultValueMap

but descriptionPropertyValue was not trim.

Change-Id: Ic05be1679436d7c6c80c4d585a301acfbeaa5cc7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add trim for descriptionPropertyValue mamh-java/extended-choice-parameter-plugin
2 participants
@chonton @mamh2021