Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-64751] Quote "docker exec" env-vars on Windows #245

Merged
merged 1 commit into from
Jan 27, 2022
Merged

[JENKINS-64751] Quote "docker exec" env-vars on Windows #245

merged 1 commit into from
Jan 27, 2022

Conversation

TBBle
Copy link
Contributor

@TBBle TBBle commented Jan 20, 2022

Based on c97bf23 from #220 which quoted "docker run" env-vars, this addresses JENKINS-64751 and JENKINS-65933.

I have not included any tests, as my understanding from #215 is that we do not have test infrastructure that supports docker-execution tests on Windows, similarly to #220.

  • Draft because:
    • I wanted initial CI results from Jenkins
    • I need to test this with the reproduction case in the comments of JENKINS-64751
    • I need to get local sign-off due to employer requirements.
  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@TBBle
Copy link
Contributor Author

TBBle commented Jan 20, 2022

Hmm. I just noticed #244, which might block testing of this on the mainline. We're on 1.26 locally, so I'll either wait for #244 to land and rebase, or test it locally with a build of this change cherry-picked onto 1.26.

Based on c97bf23 from #220, to address
JENKINS-64751 and JENKINS-65933.
@TBBle
Copy link
Contributor Author

TBBle commented Jan 20, 2022

Hmm. Both this and #244 hit an hour timeout in the CI system, and nothing's been built since six days ago, or merged into mainline since December, when it wasn't having that issue. So I suspect something's borked on the CI infrastructure side.

@TBBle
Copy link
Contributor Author

TBBle commented Jan 21, 2022

#244's latest run wasn't so slow, so I guess the CI problem has been resolved. I'm not sure how to trigger a rerun, so I'll wait to see if local testing reveals any changes, and otherwise wait for #244 or similar to land, and rebase on that to trigger a CI run.

@TBBle
Copy link
Contributor Author

TBBle commented Jan 21, 2022

Local test using mvn hpi:run and the same Windows node where I was able to produce failure before passed the same test. So I'm happy that this fix is correct, and will be trying to deploy it locally (cherry-picked onto 1.26) to get ourselves out from under this bug.

@TBBle TBBle marked this pull request as ready for review January 25, 2022 06:00
@rsandell rsandell changed the title Quote "docker exec" env-vars on Windows (JENKINS-64751) [JENKINS-64751] Quote "docker exec" env-vars on Windows Jan 27, 2022
@rsandell rsandell merged commit ef5c63b into jenkinsci:master Jan 27, 2022
@TBBle TBBle deleted the quote-docker_exec-env_vars-on-windows branch January 28, 2022 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants