Escape environment variables before pass it to docker run #215
Conversation
|
This PR should be reviewed and be accepted if the fix is correct. Because when PR title has quotes in them, it jams up our build insider docker runs. Since it only happens from time to time, we always spend hours before realizing that PR titles have quotes. |
To correctly pass it as `docker run` argument. NOTE: WindowsUtil is used because the logic seems to be the same for Linux.
To check that they are correctly escaped.
Because new tests requires docker daemon for the correct work. A 'docker' label was taken from the list of supported platforms: https://github.com/jenkins-infra/documentation/blob/master/ci.adoc
To check that environment variables with spaces are escaped before passing them to container.
|
I've tried to complete the PR using #220 as a base and cover logic with tests but encountered an issue. According to the default configuration, CI build is run on Maybe I'm doing something wrong when implementing such tests but don't see any other option to check this logic. If you have better ideas, please share them 😀 |
|
Also, I've tried to extend the list of target platform with |
In order to avoid issues with spaces.
We've used Bitbucket Branch Source Jenkins plugin which automatically adds environment variables like CHANGE_TITLE. In our case, PR title contains spaces which leads to error like:
Error: docker: invalid reference format: repository name must be lowercase.We assume that issue is because of spaces in the variable but can be wrong, please share your thoughts on this point.