Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add apiUrl to allow for separation of urls. One for UI, another for API #23

Closed
wants to merge 5 commits into from
Closed

Add apiUrl to allow for separation of urls. One for UI, another for API #23

wants to merge 5 commits into from

Conversation

jonbrohauge
Copy link

Due to changes in Dependency-Track 4.0, i.e. separate URL for UI and API. This plugin needs to have to URL-inputs, one for the UI another for the API.

@jonbrohauge jonbrohauge marked this pull request as ready for review January 18, 2021 14:28
@sephiroth-j sephiroth-j self-requested a review January 18, 2021 15:57
@sephiroth-j
Copy link
Member

Thank you for your effort, @jonbrohauge. Unfortunately I can not accept this PR. The main reason for this, is that your change is breaking change. You re-declared the existing URL to be the one for the frontend and introduced a new URL/setting for the API that actual maters the most. This would require all users to update their Jenkins settings and/or build jobs (again after plugin version 3.0)! Another reason is that you made other unnecessary changes such as reordering of imports or reformatting javadoc in a way that is different to the existing style. In its present state, updates of the documentation and changelog would be needed as well.

A good solution would be to introduce a new optional setting for the URL to the DTrack-Frontend that, if present, would be used for the URLs to the project pages. The existing URL is still the main URL that is used for both API (primary function) and frontend, unless the new URL to the frontend is given.

@sephiroth-j
Copy link
Member

closing in favor of own solution

@jonbrohauge
Copy link
Author

Whatever works. As long as there is a way to define the two url's, since there clearly needs an option to allow this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants