-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Plugin to Support Separate URL's for API and Frontend - Links to Projects do not work without this #22
Comments
Is anyone looking at this? |
@sephiroth-j Could you take a look to see if it's something remotely useful? |
@jonbrohauge, thanks for the PR, I will look at it within the next days. |
Separating Frontend and Backend was already possible in version 3.8. The bundled distribution is still available with v4.0 but deprecated. The new setting will therefore be optional. |
The frontend may be hosted on a different server and links in the log or result actions will not work in this case. references #22
@jonbrohauge , @JBlandHV : Please give this build a try. It contains the proposed fix this issue. |
@sephiroth-j Works on my machine 😉 |
@sephiroth-j This also works for me. I noticed on jobs that have already run it doesn't as I guess those URL's are already generated but new ones work like a champ. I'm not worried about the older jobs and ultimately imagine nothing much to be done about it, they'll drop out of the system over time anyway. Appreciate the fast fix on this. |
Thanks for testing. 😃
Yes, that is correct, the new URL is only used for new build jobs. This is because the URL can be specific to a job run and is therefore persisted along with the job result. |
No problems. That makes sense :) |
I'm running Dependency Track v4.0.1 using Docker where you have a separate URL for the API and another one for the Front End. To get this Jenkins plugin to work with the API you need to specify that URL, this works fine and details are shown in Jenkins on the job.
However the link that suggests to go to Dependency Track for more information, the Project link does not work because it goes to the API URL and not the Frontend URL.
My URL's are as follows:
API: dependency-check-api.domain.com
Frontend: dependency-check.domain.com
I think we just need an option to add in a second FrontEnd URL so the links in the builds will work.
Environment Information
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Opens up the Dependency Track UI at the correct project.
NOTE: This can be done manually by editing the URL to change it from the API to FrontEnd link but will be solved by having a second FrontEnd URL to be entered in the settings for the plugin
The text was updated successfully, but these errors were encountered: