Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated plugin releases #1

Merged
merged 1 commit into from
Apr 25, 2023
Merged

Automated plugin releases #1

merged 1 commit into from
Apr 25, 2023

Conversation

elmsdata
Copy link
Contributor

What

Automated plugin release based on Jenkins infrastructure documentation and capabilities.

Why

To push the plugin to Jenkins Artifactory.

Changes details

  • Created github action cd.yaml workflow
  • Create dependabot yaml file
  • Change pom versioning

Missed anything?

  • Explained the purpose of this PR.
  • Self reviewed the PR.
  • Added or updated test cases.
  • Informed of breaking changes, testing and migrations (if applicable).
  • Updated documentation (if applicable).
  • Attached screenshots (if applicable).

@elmsdata
Automated plugin releases
bd671f3 
Signed-off-by: elmsdata <Evan.Elms@fmr.com>
@elmsdata elmsdata mentioned this pull request Apr 24, 2023
Merged
10 tasks
NotMyFault
NotMyFault approved these changes Apr 25, 2023
View reviewed changes
Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My approval of the PR enabling CD at the RPU was supposed to imply this PR is good to go too :)

pom.xml
@@ -36,6 +36,8 @@
<!-- https://www.jenkins.io/doc/developer/plugin-development/choosing-jenkins-baseline/ -->
<!-- Baseline Jenkins version you use to build the plugin. Users must have this version or
newer to run. -->
<revision>1</revision>
<changelist>999999-SNAPSHOT</changelist>
<jenkins.version>2.375.4</jenkins.version>
<hpi-plugin.version>3.42</hpi-plugin.version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<hpi-plugin.version>3.42</hpi-plugin.version>

This is unneeded and configured in the parent pom, but not relevant to enabling CD.

@rorybakerfmr rorybakerfmr merged commit bd671f3 into jenkinsci:main Apr 25, 2023
@NotMyFault
Copy link
Member

NotMyFault commented Apr 25, 2023 •
edited
Loading

Oh, I forgot to mention to create a .mvn folder within the repository root and add the following files: https://github.com/jenkinsci/console-column-plugin/tree/master/.mvn

Otherwise, CD won't work.

Labeling PRs is needed too, to generate automatic changelogs.

@elmsdata elmsdata added the enhancement New feature or request label Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NotMyFault NotMyFault NotMyFault approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elmsdata @NotMyFault @rorybakerfmr