Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new CDEvents developers and automated releases #3272

Conversation

elmsdata
Copy link
Contributor

Description

https://github.com/jenkinsci/cdevents-plugin

@rorybakerfmr
@racey3542
@jplower

Submitter checklist for adding or changing permissions

Always

  • Add link to plugin/component Git repository in description above

When enabling automated releases (cd: true)

  • Add a link to the pull request, which enables continuous delivery for your plugin or component.
    Follow the documentation to ensure, your pull request is set up properly.

jenkinsci/cdevents-plugin#1

When adding new uploaders (this includes newly created permissions files)

Reviewer checklist (not for requesters!)

  • Check this if newly added person also needs to be given merge permission to the GitHub repo (please @ the people/person with their GitHub username in this issue as well). If needed, it can be done using an IRC Bot command
  • Check that the $pluginId Developers team has Admin permissions while granting the access.
  • In the case of plugin adoption, ensure that the Jenkins Jira default assignee is either removed or changed to the new maintainer.
  • If security contacts are changed (this includes add/remove), ping the security officer (currently @Wadeck) in this pull request. If an email contact is changed, wait for approval from the security officer.

There are IRC Bot commands for it

Signed-off-by: elmsdata <Evan.Elms@fmr.com>
Signed-off-by: elmsdata <Evan.Elms@fmr.com>
Signed-off-by: elmsdata <Evan.Elms@fmr.com>
@elmsdata elmsdata requested a review from a team as a code owner April 24, 2023 17:26
@NotMyFault NotMyFault added the needs initial login The users need to log in to Jira and/or Artifactory label Apr 24, 2023
@elmsdata
Copy link
Contributor Author

Closing pull request to re-trigger checks.

@elmsdata elmsdata closed this Apr 24, 2023
@elmsdata elmsdata reopened this Apr 24, 2023
@elmsdata elmsdata closed this Apr 24, 2023
@elmsdata elmsdata reopened this Apr 24, 2023
@elmsdata
Copy link
Contributor Author

Thank you @NotMyFault for catching that, completely my bad as I only validated Jira beforehand! 😄 Please let me know if anything else needs to be updated on the pull request, or whoever from the Hosting team will review it, and have a wonderful day!

Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@NotMyFault NotMyFault removed the needs initial login The users need to log in to Jira and/or Artifactory label Apr 25, 2023
@NotMyFault NotMyFault merged commit 9f21527 into jenkins-infra:master Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants