Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add spotbugs checks #107

Merged
merged 8 commits into from
Nov 8, 2022
Merged

Add spotbugs checks #107

merged 8 commits into from
Nov 8, 2022

Conversation

MarkEWaite
Copy link
Contributor

Add more spotbugs checks

  • Remove redundant null check
  • Match parameter NonNull value of method being overridden
  • Increase intensity of spotbugs checks

Resolve two warnings and leave one warning to be resolved later by others.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@MarkEWaite
Convert property files to unambiguous encoded form
ebbc900 
Japanese files include characters that could be confused with ISO-8859-1
characters.  Convert them all to encoded ASCII so that there is no
ambiguity.

Resolves a warning from the an injected test.
@MarkEWaite
Require Jenkins 2.332.4
d30c73e 
https://www.jenkins.io/doc/developer/plugin-development/choosing-jenkins-baseline/
recommends 2.332.4 as a good minimum core version.
@MarkEWaite
Use parent pom 4.49, not 4.16
f4fc8fa 
Also removes the java.level property
@MarkEWaite
Remove unused java.level property
ce0cb42
@MarkEWaite
Test more configurations in CI
89359fe
@MarkEWaite
Remove redundant null check
a0bc1f5
@MarkEWaite
Match parameter NonNull value of method being overridden
372cbad
@MarkEWaite
Increase intensity of spotbugs checks
a5cdce1
@MarkEWaite MarkEWaite enabled auto-merge November 7, 2022 22:44
gounthar
gounthar approved these changes Nov 8, 2022
View reviewed changes
Copy link

@gounthar gounthar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks. 👍

jmMeessen
jmMeessen approved these changes Nov 8, 2022
View reviewed changes
Copy link
Contributor

@jmMeessen jmMeessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MarkEWaite MarkEWaite merged commit 59931b4 into jenkinsci:master Nov 8, 2022
@MarkEWaite MarkEWaite deleted the add-spotbugs-checks branch November 8, 2022 14:25
@MarkEWaite MarkEWaite added the chore Reduces maintenance effort by changes not directly visible to users label Mar 21, 2023
@MarkEWaite MarkEWaite mentioned this pull request Mar 21, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmMeessen jmMeessen jmMeessen approved these changes

@gounthar gounthar gounthar approved these changes

Assignees
No one assigned
Labels
chore Reduces maintenance effort by changes not directly visible to users
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarkEWaite @gounthar @jmMeessen