Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let markwaite adopt authorize-project plugin again #3204

Merged
merged 1 commit into from
Mar 21, 2023

Conversation

MarkEWaite
Copy link
Contributor

Let markewaite adopt authorize-projects plugin

I'd like to adopt https://github.com/jenkinsci/authorize-project-plugin again so that I can release the configuration as code support that was initially implemented by @daxriggs and refined by @basil with improvements and additional tests.

I had adopted the plugin previously and submitted the following pull requests to improve it:

I may also enable automated releases during this adoption, since it simplifies my maintenance of the plugin.

Per https://github.com/jenkinsci/authorize-project-plugin this plugin is up for adoption.

@MarkEWaite is the GitHub user associated with the Jenkins LDAP account markewaite

Always

  • Add link to plugin/component Git repository in description above

When adding new uploaders (this includes newly created permissions files)

Reviewer checklist (not for requesters!)

  • Check this if newly added person also needs to be given merge permission to the GitHub repo (please @ the people/person with their GitHub username in this issue as well). If needed, it can be done using an IRC Bot command
  • Check that the $pluginId Developers team has Admin permissions while granting the access.
  • In the case of plugin adoption, ensure that the Jenkins Jira default assignee is either removed or changed to the new maintainer.
  • If security contacts are changed (this includes add/remove), ping the security officer (currently @Wadeck) in this pull request. If an email contact is changed, wait for approval from the security officer.

There are IRC Bot commands for it

@MarkEWaite MarkEWaite requested a review from a team as a code owner March 21, 2023 17:35
@NotMyFault NotMyFault merged commit e1d0655 into master Mar 21, 2023
@NotMyFault NotMyFault deleted the let-markewaiate-adopt-authorize-project branch March 21, 2023 18:15
@NotMyFault NotMyFault self-assigned this Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants